Skip to content

Add binding test with a map key prefixed with "/" #13421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add binding test with a map key prefixed with "/" #13421

wants to merge 2 commits into from

Conversation

nelsonklau
Copy link

This PR adds a test case as a user guide showing how to configure keys like URL.
The proper way to configure URL alike keys in yaml should look like:

application.yml 

shiro:
  testMap:
    "[/test1]": test1
    "[/test2]": test2
    "[/test3/test31]": test31

Fixes #13404

@nelsonklau
ConfigurationProperties support "/"
9a5b8e5 
This commit adds a test case as a user guide showing how to configure keys like URL.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 8, 2018
@snicoll snicoll changed the title YAML @ConfigurationProperties support "/" Add binding test with a map key prefixed with "/" Jun 15, 2018
@snicoll
Copy link
Member

snicoll commented Jun 15, 2018

@KFLAU thanks for the PR but I don't think that's actually fixing 13404. We've decided to tackle this issue and try to implement something that would be more user-friendly.

@snicoll snicoll closed this Jun 15, 2018
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow map binding to work with unescaped characters
3 participants
@nelsonklau @snicoll @spring-projects-issues