Skip to content

Stack overflow when OriginTrackedFieldError.toString() is called #14152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Stack overflow when OriginTrackedFieldError.toString() is called #14152

wants to merge 1 commit into from

Conversation

hiroakiy
Copy link

This PR fixes an IL_INFINITE_RECURSIVE_LOOP warning reported by FindBugs-3.0.1 (http://findbugs.sourceforge.net/):

H C IL: There is an apparent infinite recursive loop in org.springframework.boot.context.properties.bind.validation.OriginTrackedFieldError.toString()  At OriginTrackedFieldError.java:[line 49]

The description of the bug is as follows:

IL: An apparent infinite recursive loop (IL_INFINITE_RECURSIVE_LOOP)
This method unconditionally invokes itself. This would seem to indicate an infinite recursive loop that will result in a stack overflow.
http://findbugs.sourceforge.net/bugDescriptions.html#IL_INFINITE_RECURSIVE_LOOP

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 20, 2018
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 21, 2018
@snicoll snicoll added this to the 2.0.5 milestone Aug 21, 2018
@snicoll snicoll self-assigned this Aug 21, 2018
@snicoll snicoll changed the title Fix FindBugs warning: An apparent infinite recursive loop Fix potential infinite recursive loop in toString Aug 21, 2018
@snicoll snicoll closed this in 6e86ba1 Aug 21, 2018
snicoll added a commit that referenced this pull request Aug 21, 2018
@snicoll
Merge pull request #14152 from hiroakiy:fix-infinite-loop
59f4c5b 
* pr/14152:
  Fix potential infinite recursive loop in toString
@snicoll
Copy link
Member

snicoll commented Aug 21, 2018

@hiroakiy thank you so much for making your first contribution to Spring Boot. This is now merged in 2.0.x and master

@wilkinsona wilkinsona changed the title Fix potential infinite recursive loop in toString Stack overflow when OriginTrackedFieldError.toString() is called Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@hiroakiy @snicoll @spring-projects-issues