-
Notifications
You must be signed in to change notification settings - Fork 41.3k
Add support for configuring missingQueuesFatal property #14252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a13275f
to
23d6e43
Compare
…is setting determines whether the condition is fatal. When true, and the queues are missing during startup, the context refresh() will fail. When false, the condition is not considered fatal and the container will continue to attempt to start the consumers. -- Only for SimpleRabbitListenerContainerFactoryConfigurer When true, if the queues are removed while the container is running, the container is stopped. closes spring-projectsgh-14122
* pr/14252: Polish "Add support for configuring missingQueuesFatal property" Add support for configuring missingQueuesFatal property
Thanks again @nosan, please review the polish commit if you can. |
I've noticed those but it delegates to As for having two properties, this is an interesting question. I've paged @garyrussell for some more opinion. |
This difference is because of the internal design of the containers. With the SMLC, each consumer instance can listen to multiple queues; if any one of those queues is deleted from the broker; the consumer is killed by the broker. |
Alright, let's document that as two keys. I'll push another polish later today |
@nosan thank you very much for drawing my attention to this. I thought that the property was common since it was calling the abstract factory but it turns out that there is a subtle semantic difference that we have to explain. I took the opportunity to revisit this a bit further by exposing the difference in default values (rather than keeping `Boolean). |
see gh-14122