Skip to content

Add support for configuring missingQueuesFatal property #14252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Aug 30, 2018

see gh-14122

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 30, 2018
@nosan nosan force-pushed the gh-14122 branch 3 times, most recently from a13275f to 23d6e43 Compare August 30, 2018 15:24
…is setting determines whether the condition is fatal. When true, and the queues are missing during startup, the context refresh() will fail.

When false, the condition is not considered fatal and the container will continue to attempt to start the consumers.
 -- Only for SimpleRabbitListenerContainerFactoryConfigurer
When true, if the queues are removed while the container is running, the container is stopped.

closes spring-projectsgh-14122
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 7, 2018
@snicoll snicoll self-assigned this Sep 7, 2018
@snicoll snicoll added this to the 2.1.x milestone Sep 7, 2018
@snicoll snicoll changed the title add RabbitProperties.missingQueuesFatal property Add support for configuring missingQueuesFatal property Sep 7, 2018
@snicoll snicoll modified the milestones: 2.1.x, 2.1.0.M3 Sep 7, 2018
@snicoll snicoll closed this in c1322a5 Sep 7, 2018
snicoll added a commit that referenced this pull request Sep 7, 2018
* pr/14252:
  Polish "Add support for configuring missingQueuesFatal property"
  Add support for configuring missingQueuesFatal property
@snicoll
Copy link
Member

snicoll commented Sep 7, 2018

Thanks again @nosan, please review the polish commit if you can.

@nosan
Copy link
Contributor Author

nosan commented Sep 7, 2018

@snicoll I wanted to implement this in a similar way, but I haven't done because of the javadoc meanings. Could you please check one more time the difference between simple/direct missing-queues-fatal, just to make sure everything is ok :)

Simple , Direct

Thanks in advance.

@nosan nosan deleted the gh-14122 branch September 7, 2018 15:12
@snicoll
Copy link
Member

snicoll commented Sep 7, 2018

I've noticed those but it delegates to AbstractRabbitListenerContainerFactory so I don't think that mapping in the sub-classes was the right call.

As for having two properties, this is an interesting question. I've paged @garyrussell for some more opinion.

@garyrussell
Copy link
Contributor

When true, if the queues are removed while the container is running, the containeris stopped.

This difference is because of the internal design of the containers.

With the SMLC, each consumer instance can listen to multiple queues; if any one of those queues is deleted from the broker; the consumer is killed by the broker.
With the new container (Direct), there is a consumer for each queue, so deleting one queue doesn’t affect the other consumer(s).

@snicoll
Copy link
Member

snicoll commented Sep 7, 2018

Alright, let's document that as two keys. I'll push another polish later today

@snicoll
Copy link
Member

snicoll commented Sep 7, 2018

@nosan thank you very much for drawing my attention to this. I thought that the property was common since it was calling the abstract factory but it turns out that there is a subtle semantic difference that we have to explain. I took the opportunity to revisit this a bit further by exposing the difference in default values (rather than keeping `Boolean).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants