Skip to content

Option key validation on uniqueness #14466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Option key validation on uniqueness #14466

wants to merge 3 commits into from

Conversation

ruslanys
Copy link
Contributor

This PR is adding validation to prevent cases described in #14460.

@ruslanys ruslanys mentioned this pull request Sep 13, 2018
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 13, 2018
@ruslanys
Copy link
Contributor Author

ruslanys commented Sep 13, 2018 •
edited by wilkinsona
Loading

So, when a user executes spring init from the #14460 case, they will receive:
Option key -l duplicated. message error.

InitCommandTests will fail as well.

@ruslanys
Copy link
Contributor Author

ruslanys commented Sep 13, 2018 •
edited
Loading

If this PR is accepted, it must be merged after #14460, otherwise, the build will fail.

@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 13, 2018
@philwebb philwebb added this to the 2.0.x milestone Sep 13, 2018
@snicoll
Copy link
Member

snicoll commented Oct 9, 2018

Thanks for the suggestion and in particular to follow up on #14460 but we are not planning to make any further enhancements to the CLI at this time.

@snicoll snicoll closed this Oct 9, 2018
@snicoll snicoll removed this from the 2.0.x milestone Oct 9, 2018
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed type: task A general task labels Oct 9, 2018
@ruslanys ruslanys deleted the option-validation branch October 9, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruslanys @snicoll @philwebb @spring-projects-issues