Add a warning message if PID/LOG location uses fallback #14519
Conversation
In order to use colored console messages on initializing PID/LOG locations moved the functions above.
If the content of `PID_FOLDER` is not valid it falls back to `/tmp` without any notification. This holds for `LOG_FOLDER` too. Added a warning message to notify the user in such a case.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
the
status: waiting-for-feedback
|
Thanks for the PR. I'm not sure a warning is warranted in either case, at least not in the default launch script. Can you please explain why you think the warnings are warranted? |
|
Sure. In a customer setup each service has the same directory layout with a directory for logging and pid file. The service name is also identical across all services. Only the base directory is the name of the service itself. Unfortunately for two new services the directories for the pid folder didn't exists such that the PID file was located at The warning message only appears if the value of |
philwebb
added
the
for: team-attention
|
@wilkinsona is the feedback ok for you? |
philwebb
changed the title
philwebb
added
type: enhancement
|
Yes, thank you. We plan to include the proposed changes in 2.1. |
* gh-14519: Polish "Log a warning when using fallback for pid and log locations" Log a warning when using fallback for pid and log locations
|
Thank you for making your first contribution to Spring Boot, @agebhar1. The proposed changes have been merged into master. |
|
Thank you @wilkinsona 😃 |
If the content of
PID_FOLDERis not valid it falls back to/tmpwithout anynotification. This holds for
LOG_FOLDERtoo. Added a warning message to notifythe user in such a case.