Auto-configure Neo4J BookmarkManager when possible #14568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add Neo4jBookmarkManagementConfiguration which provides an instance of BookmarkManager if necessary and Caffeine cache is on the classpath. Depending on the kind of application, the BookmarkManager will be request scoped or singleton, as recommended by Spring Data Neo4j.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
wilkinsona
changed the title
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Oct 1, 2018
Add `Neo4jBookmarkManagementConfiguration` which provides an instance of `BookmarkManager` if necessary and Caffeine cache is on the classpath. Depending on the kind of application, the `BookmarkManager` will be request scoped or singleton, as recommended by Spring Data Neo4j. See gh-14568
philwebb
added a commit
that referenced
this pull request
Oct 1, 2018
* pr/14568: Polish Neo4J BookmarkManager auto-configuration Auto-configure Neo4J BookmarkManager when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Neo4jBookmarkManagementConfigurationwhich provides an instance ofBookmarkManagerif necessary and Caffeine cache is on the classpath.Depending on the kind of application, the
BookmarkManagerwill be request scoped or singleton, as recommended by Spring Data Neo4j.This change would provide a better getting started experience for people who want to use Neo4js bookmark support given they have all the needed dependencies (i.e. Caffeine) declared.
It's not a critical feature and especially not time relevant, given the S1P around the corner, but it would be nice to have and less error prone for the user than what there is now.