@ResponseStatus does not work when using WebFlux #14744
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This commit adds support for @ResponseStatus in DefaultErrorAttributes mimiching the semantics of @ResponseStatus in SpringMVC. Throwables annotated with @ResponseStatus handled by DefaultErrorAttributes will result in the following error attributes: * 'status' set as the return value of the HttpStatus#value() defined as @ResponseStatus#value() * 'error' set to the default reason phrase of the HttpStatus defined as @ResponseStatus#value() * 'message' defined as the value of @ResponseStatus#reason(), or the default HttpStatus's reason phrase if left unspecified Fixes spring-projects#14742
mmanciop
force-pushed
the
webflux-reason-status
branch
from
892df56 to
93f9d6f
Compare
bclozel
added
type: bug
wilkinsona
changed the title
snicoll
approved these changes
Oct 12, 2018
snicoll
pushed a commit
that referenced
this pull request
Oct 12, 2018
This commit adds support for @ResponseStatus in DefaultErrorAttributes mimicking the semantics of @ResponseStatus in SpringMVC. Throwables annotated with @ResponseStatus handled by DefaultErrorAttributes will result in the following error attributes: * 'status' set as the return value of the HttpStatus#value() defined as @ResponseStatus#value() * 'error' set to the default reason phrase of the HttpStatus defined as @ResponseStatus#value() * 'message' defined as the value of @ResponseStatus#reason(), or the default HttpStatus's reason phrase if left unspecified See gh-14744
snicoll
added a commit
that referenced
this pull request
Oct 12, 2018
* pr/14744: Polish "Add support for @ResponseStatus in DefaultErrorAttributes" Add support for @ResponseStatus in DefaultErrorAttributes
|
@mmanciop thank you for making your first contribution to Spring Boot. This is merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for @ResponseStatus in DefaultErrorAttributes
mimicking the semantics of @ResponseStatus in SpringMVC.
Throwables annotated with @ResponseStatus handled by
DefaultErrorAttributes will result in the following error attributes:
defined as @ResponseStatus#value()
defined as @ResponseStatus#value()
or the default HttpStatus's reason phrase if left unspecified
Fixes #14742