Take aliases into consideration when checking descendants #14967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chang-chao Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@chang-chao Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
added 2 commits
October 26, 2018 10:40
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added a commit
that referenced
this pull request
Oct 26, 2018
philwebb
added a commit
that referenced
this pull request
Oct 26, 2018
* pr/14967: Polish "Consider aliases when checking descendants" Consider aliases when checking descendants
philwebb
added
type: bug
|
Thanks very much for the PR. This is now in 2.0.x and master with some slight modifications. |
chang-chao
deleted the
aliasedconfigurationpropertysource_containsdescendantof
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AliasedConfigurationPropertySourceclass does not properly treat aliases incontainsDescendantOf method.For example, in the following case,
containsDescendantOf("baz")should returntrue, but currentlyfalseis returned.source property:
bar.foo = barValue
alias:
bar.foo -> baz.foo
This PR fixes this issue.