Fix MetricsAutoConfigurationTests #14972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
philwebb
added a commit
that referenced
this pull request
Oct 26, 2018
* pr/14972: Fix MetricsAutoConfigurationTests
|
I'm surprised the field access worked at all with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while working on another PR I stumbled upon a test failure in MetricsAutoConfigurationTests caused by changes in micrometer.
In theory, this should work without the removal of the spy() call (although it's not needed here anyway if you ask me), but it doesn't. With the spy() call the array is empty, without it it's filled. I wonder why, but maybe you can enlighten me. Maybe because the field is volatile now?
Let me know what you think.
Cheers,
Christoph