Change DataSourceHealthIndicator details from "hello" to "result" #15136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: enhancement
|
@restolho thanks for opening your first pull request to Spring Boot. It looks good. We can't merge it just yet as the |
wilkinsona
changed the title
snicoll
approved these changes
Dec 3, 2018
snicoll
added a commit
that referenced
this pull request
Dec 3, 2018
* pr/15136: Change DataSourceHealthIndicator details from "hello" to "result"
|
@restolho thank you very much for making your first contribution to Spring Boot. This is now merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15114
Changes:
Modified DataSourceHealthIndicator details from "hello" to "result" and updated tests accordingly.
Also while doing a clean install with IntelliJ i had several errors about multiple files not being properly formatted on the following location (spring-boot\spring-boot-project\spring-boot-tools\spring-boot-test-support\src\test\java\org\springframework\boot\testsupport). I didn't commit any changes regarding this, since i don't know if this was a local problem or if there is in fact a problem with them.