Skip to content

Conversation

dileepbapat
Copy link
Contributor

This is to remove unwanted spaces in the configuration file for log level.

@pivotal-issuemaster
Copy link

@dileepbapat Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@dileepbapat Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 9, 2018
@philwebb
Copy link
Member

philwebb commented Nov 9, 2018

@dileepbapat Did you have a specific issue that lead you to wanting this change? I'm curious how you were specifying the logging levels (YAMl, Properties, Environment Variable).

I'm also wondering if the code wouldn't be better in the coerceLogLevel method. We should also add a test for this.

@philwebb philwebb added the status: waiting-for-feedback We need additional information before we can continue label Nov 9, 2018
@dileepbapat
Copy link
Contributor Author

Yes, setting in property file or environment variable are having this issue. I haven't checked with yaml.

Yeah it make sense to move it to coerceLogLevel and add tests. will check no that

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Nov 19, 2018
@philwebb philwebb added this to the 2.1.x milestone Nov 19, 2018
@wilkinsona wilkinsona changed the title Avoid extra spaces in configuration file for log level Trim whitespace from configured value for a log level Nov 27, 2018
@wilkinsona wilkinsona self-assigned this Nov 27, 2018
wilkinsona pushed a commit that referenced this pull request Nov 27, 2018
wilkinsona added a commit that referenced this pull request Nov 27, 2018
* gh-15143:
  Polish "Trim whitespace when coercing to a LogLevel"
  Trim whitespace when coercing to a LogLevel
@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.1 Nov 27, 2018
@wilkinsona
Copy link
Member

@dileepbapat Thank you very much for making your first contribution to Spring Boot. I have merged your changes into master along with a polish commit that, primarily, makes the change suggested by @philwebb and adds a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants