Skip to content

Support server.connection-timeout for Netty server #15385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support server.connection-timeout for Netty server #15385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .../org/springframework/boot/autoconfigure/web/embedded/NettyWebServerFactoryCustomizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@

package org.springframework.boot.autoconfigure.web.embedded;

import java.time.Duration;

import io.netty.channel.ChannelOption;

import org.springframework.boot.autoconfigure.web.ServerProperties;
import org.springframework.boot.cloud.CloudPlatform;
import org.springframework.boot.context.properties.PropertyMapper;
Expand All @@ -31,6 +35,7 @@
*
* @author Brian Clozel
* @author Chentao Qu
* @author Artsiom Yudovin
* @since 2.1.0
*/
public class NettyWebServerFactoryCustomizer
Expand Down Expand Up @@ -60,6 +65,10 @@ public void customize(NettyReactiveWebServerFactory factory) {
.asInt(DataSize::toBytes)
.to((maxHttpRequestHeaderSize) -> customizeMaxHttpHeaderSize(factory,
maxHttpRequestHeaderSize));
propertyMapper.from(this.serverProperties::getConnectionTimeout).whenNonNull()
.asInt(Duration::toMillis)
.to((duration) -> customizeConnectionTimeOut(factory, duration));

}

private boolean getOrDeduceUseForwardHeaders(ServerProperties serverProperties,
Expand All @@ -78,4 +87,12 @@ private void customizeMaxHttpHeaderSize(NettyReactiveWebServerFactory factory,
.maxHeaderSize(maxHttpHeaderSize)));
}

private void customizeConnectionTimeOut(NettyReactiveWebServerFactory factory,
int duration) {
factory.addServerCustomizers((NettyServerCustomizer) (httpServer) -> httpServer
.tcpConfiguration((tcpServer) -> tcpServer
.bootstrap((serverBootstrap) -> serverBootstrap.childOption(
ChannelOption.CONNECT_TIMEOUT_MILLIS, duration))));
}

}