Unlike Jetty and Tomcat, Reactor Netty and Undertow do not cause a startup failure when SSL is enabled but no key store is configured #15709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artup failure when SSL is enabled but no key store is configured issue fixed.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
wilkinsona
pushed a commit
that referenced
this pull request
Jan 22, 2019
wilkinsona
added a commit
that referenced
this pull request
Jan 22, 2019
* gh-15709: Polish "Always fail fast when SSL is enabled without a key store" Always fail fast when SSL is enabled without a key store
|
Thanks very much for the pull request, @Raheela1024. It's great to see you making another contribution after taking care of a first-timers only issue for us. I did a little bit of polishing that you might be interested in. I tweaked some of the exceptions that are thrown to make things even more consistent across containers and also added a few tests to hopefully verify that the behaviour is consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…artup failure when SSL is enabled but no key store is configured issue fixed.