Complete Jetty Access Log configuration properties support #16080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I'll confess I am not sure how ssl related tests in the undertow test class are affected by my diff. I'll try to debug more and see if I am triggering the failure but this seems fishy. |
|
@nhomble Thanks for the pull request. The problem with Undertow looks to be unrelated. Please feel free to ignore it. |
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Apr 17, 2019
snicoll
added a commit
that referenced
this pull request
Apr 17, 2019
* pr/16080: Polish "Complete Jetty Access Log configuration properties support" Complete Jetty Access Log configuration properties support
|
@nhomble thank you for making your first contribution to Spring Boot. Your contribution is now merged on |
|
thanks a lot @snicoll! I hope to find more thing to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing ignorePaths from
NCSARequestLoginto the jetty access log configuration so that users can choose to not log a URI in their request logs as supported out of the box by jetty.This resolves #15677