Skip to content

Conversation

spencergibb
Copy link
Member

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 9, 2019
@snicoll snicoll self-assigned this Mar 9, 2019
@snicoll snicoll changed the title Changes hasBeenBound to return false if there is no bean definition Fail to bind ConfigurationProperties bean with no BeanDefinition Mar 9, 2019
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 9, 2019
@snicoll snicoll added this to the 2.2.0.M2 milestone Mar 9, 2019
snicoll added a commit that referenced this pull request Mar 9, 2019
@snicoll
Copy link
Member

snicoll commented Mar 9, 2019

Thanks @spencergibb. Unfortunately that test passes for me. I've tried to make it fail and was unable to do so. I also wanted to fix the issue slightly differently which is done in d07a6ff with a test. It would be nice to test what actually happens in you case so we're still interested by a test if you manage to get one failing without that commit. Thanks for the PR, in any case.

@snicoll snicoll closed this Mar 9, 2019
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed type: bug A general bug labels Mar 9, 2019
@snicoll snicoll removed their assignment Mar 9, 2019
@snicoll snicoll removed this from the 2.2.0.M2 milestone Mar 9, 2019
@spencergibb
Copy link
Member Author

Yeah, I could never run the test, so I want sure if it worked. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants