Skip to content

Test against Gradle 5.3 #16294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dreis2211
Copy link
Contributor

Hi,

as Gradle 5.3 was released a few days ago, we should probably test against it.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 22, 2019
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 22, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Mar 22, 2019
@pkostrzewa
Copy link
Contributor

pkostrzewa commented Mar 24, 2019

Tested against example provided in gh-16211 which resulted in Main class name has not been configured and it could not be resolved as before.

@wilkinsona
Copy link
Member

wilkinsona commented Mar 25, 2019

@pkostrzewa Thanks, but there’s no need to spend time on manual testing. This PR means that the test suite (that found the regression I reported to Gradle) will run against 5.3 automatically. The PR’s checks have passed and one of those checks is a CI build.

@snicoll snicoll self-assigned this Mar 25, 2019
@snicoll snicoll modified the milestones: 2.1.x, 2.1.4 Mar 25, 2019
snicoll added a commit that referenced this pull request Mar 25, 2019
* pr/16294:
  Test against Gradle 5.3
@snicoll snicoll closed this in c2335e1 Mar 25, 2019
@snicoll
Copy link
Member

snicoll commented Mar 25, 2019

Thanks Christoph, this is now merged in 2.1.x and master.

@pkostrzewa
Copy link
Contributor

@wilkinsona Thanks for information, actually it took no more than few minutes. But I wasn't aware of that fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants