Skip to content

Cache MimeTypes to improve performance #16507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Cache MimeTypes to improve performance #16507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f9e366
Call MimeTypeUtils::parseMimeType earlier to improve performance
Apr 10, 2019
1b4bd4a
Call MimeTypeUtils::parseMimeType earlier to improve performance
Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...boot/src/main/java/org/springframework/boot/web/embedded/netty/CompressionCustomizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
package org.springframework.boot.web.embedded.netty;

import java.util.Arrays;
import java.util.List;
import java.util.function.BiPredicate;
import java.util.stream.Collectors;

import io.netty.handler.codec.http.HttpHeaderNames;
import io.netty.handler.codec.http.HttpHeaders;
Expand Down Expand Up @@ -64,14 +66,18 @@ private CompressionPredicate getMimeTypesPredicate(String[] mimeTypes) {
if (ObjectUtils.isEmpty(mimeTypes)) {
return ALWAYS_COMPRESS;
}

List<MimeType> mimeTypeList = Arrays.stream(mimeTypes)
.map(MimeTypeUtils::parseMimeType).collect(Collectors.toList());

return (request, response) -> {
String contentType = response.responseHeaders()
.get(HttpHeaderNames.CONTENT_TYPE);
if (StringUtils.isEmpty(contentType)) {
return false;
}
MimeType contentMimeType = MimeTypeUtils.parseMimeType(contentType);
return Arrays.stream(mimeTypes).map(MimeTypeUtils::parseMimeType)
return mimeTypeList.stream()
.anyMatch((candidate) -> candidate.isCompatibleWith(contentMimeType));
};
}
Expand Down