Skip to content

Upgrade to Kotlin 1.3.30 #16554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade to Kotlin 1.3.30 #16554

wants to merge 1 commit into from

Conversation

sdeleuze
Copy link
Contributor

@sdeleuze sdeleuze commented Apr 13, 2019 •
edited
Loading

Please merge this for Boot 2.2.0.M2.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 13, 2019
snicoll
snicoll reviewed Apr 13, 2019
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdeleuze this wasn't the version Spring Framework M2 was compiled against. I assume you're aware and want to proceed anyway?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Apr 13, 2019
@sdeleuze
Copy link
Contributor Author

Yes

@snicoll snicoll added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2019
@snicoll snicoll self-assigned this Apr 15, 2019
@snicoll snicoll added this to the 2.2.0.M2 milestone Apr 15, 2019
@snicoll snicoll closed this in 86c75b9 Apr 15, 2019
snicoll added a commit that referenced this pull request Apr 15, 2019
@snicoll
Merge pull request #16554 from sdeleuze
3385e03 
* pr/16554:
  Upgrade to Kotlin 1.3.30
@snicoll snicoll mentioned this pull request Apr 15, 2019
Closed
@snicoll
Copy link
Member

snicoll commented Apr 15, 2019

This broke the integration tests of our gradle plugin apparently.

@snicoll snicoll reopened this Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll left review comments

Assignees

@snicoll snicoll

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.2.0.M2
Development

Successfully merging this pull request may close these issues.
3 participants
@sdeleuze @snicoll @spring-projects-issues