Improve server factory with apply customizers #16584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UndertowBuilderCustomizer, JettyServerCustomizer beans automatically Fixes spring-projectsgh-16514
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks @SergeyHydra. The PR is missing tests. The original issue has links to tests for both the servlet and reactive cases. |
mbhave
added
the
status: waiting-for-feedback
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
mbhave
added
type: enhancement
Closed
4 tasks
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
mbhave
pushed a commit
that referenced
this pull request
Apr 22, 2019
mbhave
added a commit
that referenced
this pull request
Apr 22, 2019
* pr/16584: Polish "Apply server customizer beans automatically" Apply server customizer beans automatically
|
@SergeyHydra Thank you for your first contribution to Spring Boot. This is now merged into master along with this polish commit. The polish commit mainly addresses the tests and fixes some checkstyle issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply UndertowDeploymentInfoCustomizer and
UndertowBuilderCustomizer, JettyServerCustomizer beans automatically
Fixes gh-16514