-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Added Cassandra Cluster factory and Default implementation. #16702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the default cassandra builder to be overwritten. This is useful for example when implementing jaeger/opentracing
@ssoerensen Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@ssoerensen Thank you for signing the Contributor License Agreement! |
Is that using a decorator pattern of some sort? I don't think increasing the surface area with an extra callback is actually worth it. Have you tried to use a |
It was my first thought to use a
|
Thanks for the feedback. I am still not convinced we should create an interface for that specific use case. Perhaps we could expose the Flagging for team attention to see what the rest of the team thinks. |
@ssoerensen Thank you very much for making your first contribution to Spring Boot. The proposed changes have been merged into master, along with a polish commit. The two main changes were to remove the default implementation of the new interface and to add a test. |
This allows the default cassandra builder to be overwritten. This is useful for example, when implementing jaeger/opentracing