Skip to content

Conversation

gauravbhtngr
Copy link

Creating this pr (for #17037) to help removing deprecated pom property spring.version

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 2, 2019
@mbhave mbhave changed the title Dropping deprecated spring.version and using spring.freamwork.version as ref Dropping deprecated spring.version and using spring.framework.version as ref Jun 3, 2019
@mbhave
Copy link
Contributor

mbhave commented Jun 3, 2019

Since there were a lot of usages of spring.version which hadn't been changed to spring-framework.version, we might need to split this PR and merge the usages and deprecate spring.version at a later time.

@gauravbhtngr
Copy link
Author

Hey @mbhave Thanks for the reply
I see spring-framework-version itself using spring.version
<spring-framework.version>${spring.version}</spring-framework.version>
Do you think it still will cause the issue ?

How do you want me to split the pr ? leave the usages changes and do not remove spring.version with this pr, spring.version is already deprecated

@mbhave
Copy link
Contributor

mbhave commented Jun 3, 2019

@wilkinsona pointed out that most usages are only in integration tests so we can merge this as is.

@gauravbhtngr
Copy link
Author

Thanks

@gauravbhtngr

This comment has been minimized.

@snicoll

This comment has been minimized.

@wilkinsona wilkinsona added for: team-attention An issue we'd like other members of the team to review type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 4, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Jun 4, 2019
@wilkinsona wilkinsona changed the title Dropping deprecated spring.version and using spring.framework.version as ref Drop deprecated spring.version pom property in favor of spring-framework.version Jun 4, 2019
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed type: task A general task labels Jun 4, 2019
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Jun 5, 2019
@gauravbhtngr gauravbhtngr force-pushed the pr-drop-deprecated-spring-version branch from c416de9 to fdbec3a Compare June 6, 2019 16:13
@gauravbhtngr
Copy link
Author

Resolved the conflict and rebased

philwebb pushed a commit that referenced this pull request Jun 13, 2019
@philwebb philwebb closed this in 587e647 Jun 13, 2019
@philwebb
Copy link
Member

Thanks very much @gauravbhtngr, this change has now been merged into master.

@philwebb philwebb modified the milestones: 2.2.x, 2.2.0.M4 Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants