Use DeferredLog in CloudFoundryVcapEnvironmentPostProcessor #19027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2019 11:31
Use DeferredLog in CloudFoundryVcapEnvironmentPostProcessor since the logging system is not yet initialized when the EnvironmentPostProcessor's are invoked.
Receiving the ApplicationPreparedEvent is a prerequisite for being able to use DeferredLog in CloudFoundryVcapEnvironmentPostProcessor.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Nov 16, 2019
| @@ -89,9 +90,9 @@ | |||
| * @author Andy Wilkinson | |||
| * @since 1.3.0 | |||
| */ | |||
| public class CloudFoundryVcapEnvironmentPostProcessor implements EnvironmentPostProcessor, Ordered { | |||
| public class CloudFoundryVcapEnvironmentPostProcessor implements EnvironmentPostProcessor, Ordered, ApplicationListener<ApplicationEvent> { | |||
There was a problem hiding this comment.
You could implement ApplicationListener<ApplicationPreparedEvent> instead and avoid the if check in the listener implementation.
There was a problem hiding this comment.
Thank you for pointing that out. Fixed with a9c1e03
snicoll
added
for: team-attention
Directly listen for ApplicationPreparedEvent instead of ApplicationEvent and avoid the event type check.
|
This seems to me like something that we should fix in 2.1.x. The fix doesn't look risky so I suspect I've missed something. What's making you unsure, @snicoll? |
|
I can’t remember now. Thanks for confirming! |
snicoll
removed
for: team-attention
snicoll
pushed a commit
that referenced
this pull request
Nov 21, 2019
snicoll
added a commit
that referenced
this pull request
Nov 21, 2019
This was referenced Nov 21, 2019
|
@markbigler thank you for making your first contribution to Spring Boot. This is merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not wrong, currently nothing will be logged because the logging system has not yet been initialized when the EnvironmentPostProcessor's are invoked.
This PR makes use of the DeferredLog, so the log entries are no longer lost and become visible as soon as the logging system is ready.