ssl.enabled is ignored when Rabbit is configured with an address with no protocol #19109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
Nov 25, 2019
| @@ -188,7 +188,7 @@ public void setAddresses(String addresses) { | |||
| private List<Address> parseAddresses(String addresses) { | |||
| List<Address> parsedAddresses = new ArrayList<>(); | |||
| for (String address : StringUtils.commaDelimitedListToStringArray(addresses)) { | |||
| parsedAddresses.add(new Address(address)); | |||
| parsedAddresses.add(new Address(address, getSsl().isEnabled())); | |||
There was a problem hiding this comment.
Not super keen on passing this info down into Address#init but doing so make all downstream processing in Address hinge off of Address.secureConnection.
|
@wilkinsona I think this addresses the concerns. |
snicoll
pushed a commit
to snicoll/spring-boot
that referenced
this pull request
Nov 25, 2019
snicoll
added a commit
to snicoll/spring-boot
that referenced
this pull request
Nov 25, 2019
snicoll
changed the title
snicoll
added
type: regression
snicoll
added a commit
that referenced
this pull request
Nov 25, 2019
There is a direct link between the sslEnabled flag and the default port that should be used by an address. The checks are currently set in two places: * Determine which port should be used * Determine if SSL should be enabled This commit polishes the initial proposal so that secureConnection is only set if a protocol is available. See gh-19109
This was referenced Nov 25, 2019
|
@Bono007 thank you for making your first contribution to Spring Boot. Agreed on that ssl flag, I've tried a few options and this one is the least bad option. I've moved its processing in a different place though, making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ssl enabled flag when RabbitProperties specify address with no protocol.
Closes gh-19102