server.ssl.key-alias is ignored when configuring Netty #19197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: bug
wilkinsona
changed the title
This was referenced Dec 5, 2019
wilkinsona
pushed a commit
that referenced
this pull request
Dec 5, 2019
wilkinsona
added a commit
that referenced
this pull request
Dec 5, 2019
|
@Bono007 Thank you very much for making your first contribution to Spring Boot. The proposed changes have been merged into 2.1.x, 2.2.x, and master. |
philwebb
added a commit
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-17944
Followed similar approach as in
org.springframework.boot.web.embedded.jetty.SslServerCustomizerby wrapping the returned key managers with a version that supports looking up by alias. It was one level deeper as Netty passes the KeyManagerFactory, not the KeyManagers down into the bowels of SSL. With this change, the KeyManagerFactory actually returns the wrapped KeyManagers via its SPI.Verified that an invalid alias name does the same exception at runtime as reported by #16168. They are in parity w/ this change.