Profile with comma in name does not work in tests #19556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
wilkinsona
reviewed
Jan 7, 2020
...t-test/src/test/java/org/springframework/boot/test/context/SpringBootContextLoaderTests.java
Outdated
Show resolved
Hide resolved
wilkinsona
reviewed
Jan 7, 2020
...t-test/src/test/java/org/springframework/boot/test/context/SpringBootContextLoaderTests.java
Outdated
Show resolved
Hide resolved
Prior to this commit, active profiles were being added to the Spring Boot application environment by setting the `spring.profiles.active` property. This could result in profiles getting parsed differently than other uses of `@ActiveProfiles`. Setting the profiles directly in the `Environment` prevents this parsing. Fixes spring-projects#19537
scottfrederick
force-pushed
the
gh-18482
branch
from
2992477 to
32b3a55
Compare
mbhave
pushed a commit
that referenced
this pull request
Jan 7, 2020
Prior to this commit, active profiles were being added to the Spring Boot application environment by setting the `spring.profiles.active` property. This could result in profiles getting parsed differently than other uses of `@ActiveProfiles`. Setting the profiles directly in the `Environment` prevents this parsing. See gh-19556
This was referenced Jan 7, 2020
|
This change has been reverted in 2.1.13 as it introduced a regression. See #19788 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, active profiles were being added to the Spring Boot application environment by setting the
spring.profiles.activeproperty. This could result in profiles getting parsed differently than other uses of@ActiveProfiles. Setting the profiles directly in theEnvironmentprevents this parsing.Fixes #19537