Skip to content

Conversation

Abdullah8006
Copy link
Contributor

Updated minor grammar mistakes in the README.adoc file.

Updated minor grammer mistakes
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 20, 2020
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made some suggestions, can you have a look?

README.adoc Outdated
@@ -233,5 +233,5 @@ Boot step-by-step:


== License
Spring Boot is Open Source software released under the
Spring Boot is an Open Source software released under the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the current phrasing is correct.

README.adoc Outdated
@@ -102,7 +102,7 @@ need JDK 1.8.
$ ./gradlew publishToMavenLocal
----

This will build all of the jars and documentation and publish every to your local
This will build all of the jars and documentation and publish it to your local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't them more appropriate here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snicoll true

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jan 20, 2020
Updated the files as suggested by @snicoll
@snicoll snicoll changed the title Update README.adoc Polish README.adoc Jan 20, 2020
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jan 20, 2020
@snicoll snicoll added this to the 2.3.0.M1 milestone Jan 20, 2020
snicoll pushed a commit that referenced this pull request Jan 20, 2020
@snicoll snicoll closed this in 59abba3 Jan 20, 2020
@snicoll
Copy link
Member

snicoll commented Jan 20, 2020

Thanks for the follow-up @Abdullah8006 and for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants