Skip to content

Upgrade to Flyway 6.2 and support new validate migration naming property #19894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade to Flyway 6.2 and support new validate migration naming property #19894

wants to merge 1 commit into from

Conversation

kedar-joshi
Copy link
Contributor

@kedar-joshi kedar-joshi commented Jan 23, 2020 •
edited
Loading

This PR adds support for property flyway.validateMigrationNaming, which is added in Flyway v6.2.0 for validating naming convention of the migration files. See https://github.com/flyway/flyway/releases/tag/flyway-6.2.0.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 23, 2020
@snicoll
Copy link
Member

snicoll commented Jan 23, 2020 •
edited
Loading

@kedar-joshi thank you for the PR. Small note: going forward, please prepare the PR on your local copy as each commit sends a notification to 3K+ watchers.

@kedar-joshi
Copy link
Contributor Author

@kedar-joshi thank you for the PR. Small note. Going forward, please prepare the PR on your local copy as each commit sends a notification to 3K+ watchers.

Noted, thanks. I will take care of this in the future.

@kedar-joshi kedar-joshi marked this pull request as ready for review January 23, 2020 18:09
wilkinsona
wilkinsona reviewed Jan 25, 2020
View reviewed changes
...ure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration.java Outdated
@@ -134,6 +134,7 @@ public Flyway flyway(FlywayProperties properties, DataSourceProperties dataSourc
configureFlywayCallbacks(configuration, orderedCallbacks);
List<JavaMigration> migrations = javaMigrations.stream().collect(Collectors.toList());
configureJavaMigrations(configuration, migrations);
configureValidateMigrationNaming(configuration, properties.isValidateMigrationNaming());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging, we should move this down into configureProperties and add a comment to note why a method reference isn't being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@wilkinsona wilkinsona changed the title Adds support for Flyway v6.2.0 Upgrade to Flyway 6.2 and support new validate migration naming property Jan 25, 2020
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 25, 2020
@wilkinsona wilkinsona added this to the 2.3.x milestone Jan 25, 2020
@wilkinsona wilkinsona added the for: merge-with-amendments Needs some changes when we merge label Jan 25, 2020
@snicoll snicoll self-assigned this Jan 27, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.0.M2 Jan 27, 2020
snicoll pushed a commit that referenced this pull request Jan 27, 2020
@locationguru-kedarjoshi @snicoll
Upgrade to Flyway 6.2.0
0ae075e 
See gh-19894
snicoll added a commit that referenced this pull request Jan 27, 2020
@snicoll
Polish "Upgrade to Flyway 6.2.0"
ed14173 
See gh-19894
@snicoll snicoll closed this in 2cb6612 Jan 27, 2020
@kedar-joshi kedar-joshi deleted the features/flyway-6.2.0 branch January 27, 2020 15:02
@kedar-joshi
Copy link
Contributor Author

Hi, considering v2.3.0 GA is months away, I am wondering if there is any plan to backport this to v2.2.x.

@wilkinsona
Copy link
Member

We don’t have any plans to back port this. We won’t upgrade to a new minor of Flyway in a maintenance release of Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona left review comments

Assignees

@snicoll snicoll

Labels
for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement
Projects
None yet
Milestone
2.3.0.M2
Development

Successfully merging this pull request may close these issues.
5 participants
@kedar-joshi @snicoll @wilkinsona @spring-projects-issues @locationguru-kedarjoshi