Configure tests using TestContainer to use the actual container IP address #21480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt localhost can cause issue in some environement Signed-off-by: olivier lamy <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
bsideup
reviewed
May 18, 2020
| @@ -74,7 +74,7 @@ static void createBucket() { | |||
| void setUp() { | |||
| this.context = new AnnotationConfigApplicationContext(); | |||
| this.context.register(CouchbaseAutoConfiguration.class); | |||
| TestPropertyValues.of("spring.couchbase.bootstrap-hosts=localhost", | |||
| TestPropertyValues.of("spring.couchbase.bootstrap-hosts=" + couchbase.getContainerIpAddress(), | |||
There was a problem hiding this comment.
FYI Testcontainers 1.14.2 adds getHost() (returns the same value as getContainerIpAddress() but less confusing), consider using it once Spring Boot updates TC to 1.14.2
|
@wilkinsona as you are the main contributor of https://github.com/spring-gradle-plugins/dependency-management-plugin any idea regarding the question about dependencies? Do you prefer create a separate issue for that? |
|
@olamy Hard to say right now as I'm not sure what the problem is. The link you shared above 404s for me. Private repo, perhaps? |
|
@wilkinsona oh sorry it's now public. |
snicoll
added
type: task
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
May 25, 2020
snicoll
added a commit
that referenced
this pull request
May 25, 2020
|
Thanks for the PR Olivier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the Jetty project we want to have daily/weekly of Opensource project using Jetty but with last SNAPSHOT. To be sure we are not breaking anything :)
As our CI environment is based on K8s pods, using localhost for docker images started with testcontainers doesn't work.
I just made the changes to get it working (see https://jenkins.webtide.net/job/external_oss/job/spring-boot-build-jetty-9.4.x-snapshot/) and using the testcontainer recommended usage https://www.testcontainers.org/features/networking/#getting-the-container-ip-address.
Another question I have (maybe can be in a separate issue If you prefer?).
I looked at implementing this SNAPSHOT build for spring-boot/spring-framework but with the gradle build. Unfortunately I cannot change the jetty version dynamically. I tried different way but as it's using mavenBom and not the usual gradle dependency management system (this doesn't work see script here: https://github.com/jetty-project/external-oss-builds/blob/master/init.gradle.spring-framework)
If you have any idea/trick please let me know?
Signed-off-by: olivier lamy [email protected]