Skip to content

Polish #23762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Polish #23762

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 20, 2020

This PR fixes some typos and polishes trivial stuff.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 20, 2020
@@ -140,7 +140,7 @@ boolean isDriverCompatible(String driverClass) {
* database type.
* @param driverClass the driver class
* @return true if the driver class is one of the embedded types
* @deprecated since 2.3.5 in favor of {@link #isEmbedded(String, String)}
* @deprecated since 2.4.0 in favor of {@link #isEmbedded(String, String)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rah. Of course I overlooked that when we've decided to revert it.

Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot again @izeye 🙏

@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 20, 2020
@snicoll snicoll self-assigned this Oct 20, 2020
@snicoll snicoll added this to the 2.4.0-RC1 milestone Oct 20, 2020
snicoll pushed a commit that referenced this pull request Oct 20, 2020
snicoll added a commit that referenced this pull request Oct 20, 2020
@snicoll snicoll closed this in 21f2b95 Oct 20, 2020
@izeye izeye deleted the polish-20201020 branch October 20, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants