-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Remove unnecessary throws declaration in tests #26441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -80,7 +79,7 @@ void close() { | |||
} | |||
|
|||
@Test | |||
void dataSourceIsAvailableFromJndi() throws IllegalStateException, NamingException { | |||
void dataSourceIsAvailableFromJndi() throws IllegalStateException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IllegalStateException
is unchecked so it doesn't need to be declared either. It'd be nice to get rid of those too if you have the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let me do it, I think there may be many similar problems in this project, I will check them one by one in the next two days, please do not merge too early
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much. I'll mark this as a draft for now so that we know it's not quite ready to be merged.
469de88
to
4d24f60
Compare
@wilkinsona I have checked all the test cases and erased them. You can take time to review them again. In addition, I created a new branch based on the older main branch, so there is a file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many files whose year in the license header has not been updated. Is it okay to not update it?
😅 I forgot about it. It must be updated, let me make a quick change |
@cuspymd For future reference, we don't require pull-requests to be 100% perfect and it's fine if things like copyright headers aren't updated. We don't want to put people off contributing. We'll generally fix that kind of thing up during the merge. |
@philwebb Thanks for responding. I also find it very inefficient to change the license header. It seems that policies related to this are different for each spring-project. For example |
@cuspymd the coding style guide in spring framework is mostly intended to the team. We don't expect contributors to read and apply all these rules. As Phil mentioned, we're happy to fine tune formatting and conventions and don't expect PRs to be 100% perfect. In short, the review you did above isn't necessary, thank you. |
Thanks again @weixsun |
@snicoll Thanks for the explanation. In the future, I will not review the coding style. |
This pr is only used to check the test method.