Skip to content

Add SpringInfoContributor to expose Spring Framework/Boot version on info actuator #28884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

madorb
Copy link

@madorb madorb commented Dec 1, 2021

This PR provides an opt-in InfoContributor that exposes the Spring and SpringBoot versions on the info actuator endpoint.

This is controlled by the property management.info.spring.enabled=true

If true it will expose the data as:

"spring:" {
  "springBootVersion": "x.x.x",
  "springFrameworkVersion": "y.y.y"
}

though, there is likely a better naming convention, open to suggestions

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 1, 2021
@wilkinsona
Copy link
Member

We should consider #22924 when evaluating this.

@madorb
Copy link
Author

madorb commented Dec 2, 2021

@wilkinsona ah, that's an interesting ticket. i actually just recently built a similar capability - as you mention there, in my app's gradle script itself. Thus it's not based on anything spring knows or the actual contents of the generated jar, but based on what gradle reports its runtime dependencies as. While familiar with the SBOM concept, I was unfamiliar with cyclonedx... it looks like it's also got a gradle plugin, so, could likely cover the vast majority of spring projects if it made sense to expose the generated SBOM.

@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Dec 10, 2021
@philwebb philwebb self-assigned this Dec 15, 2021
@philwebb
Copy link
Member

Thanks for the PR, but I think we should roll this one into #22924. If we add a dedicated SpringInfoContributor now, we're likely going to want to change it when #22924 lands.

@philwebb philwebb closed this Jan 10, 2022
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants