@ConditionalOnMissingBean now also checks beans available via FactoryBeans

[jkubrynski]

Fixed approach from previous pull request to validate if there are beans related to @ConditionalOnMissingBean available via BeanFactory

Works fully on generics, without instantiating any bean

[philwebb]

Thanks for the pull request and for raising #352.

I have made a few tweaks [1] to also deal with the XML test which was previously not failing because it didn't include the @Conditional bean.

I think your approach is generally sensible but I would like @dsyer to review the updated patch to ensure there aren't any unexpected side-effects. I am also wondering if this is something that the core Spring Framework should deal with directly, rather than something that is specific to Spring Boot? Perhaps this is something we should push upstream?

[1] https://github.com/philwebb/spring-boot/tree/gh-355

[jkubrynski]

Thanks for tweaks. I think you're probably right and this is something that should be pushed to Spring Core. In fact it'll be probably a bigger change (due to there will be no more need to instantiate beans, so both boolean parametrs used to tune resolving won't be longer needed) - I'll take a look at this.

[dsyer]

Merged, thanks. Definitely this code should be in BeanFactoryUtils (cc@ @jhoeller).