Skip to content

Added detecting protocol, username and password in ElasticsearchConta… #39092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pioorg
Copy link

@pioorg pioorg commented Jan 11, 2024

Improve Elasticsearch ServiceConnection #35926

Currently only Elasticsearch 7.x works with @ServiceConnection without any additional (manual) configuration or disabling security and SSL.

The proposed changes make it possible to use also:

  • version 8.x (where security and SSL are enabled by default)
  • version 7.x with with security and SSL enabled.

It is achieved by:

  • detecting if SSL is in place (therefore needing HTTPS)
  • security is enabled (thus requiring username and password)

…inerConnectionDetailsFactory for versions 7.x and 8.x.
@pivotal-cla
Copy link

@pioorg Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 11, 2024
@wilkinsona
Copy link
Member

Thanks, @pioorg. Unfortunately, as indicated by it being assigned to someone, #35926 is already being worked on. There's also an existing prototype linked to in the issue's comments.

@wilkinsona wilkinsona closed this Jan 11, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 11, 2024
@pioorg
Copy link
Author

pioorg commented Jan 11, 2024

Hello @wilkinsona
I saw both prototypes mentioned in the issue and the issue is that (in my understanding), they won't work, because they assume security and HTTPS always come together, and are always present/mandatory in 8.x, and never working in 7.x. This assumption is not correct, I'm afraid.
I also made a comment in the issue.
I'm not interested in this PR being merged. What I'm after is having a working and correct solution.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants