Skip to content

ResolveMainClassName calls getProject() at execution time, making it incompatible with Gradle's configuration cache #39644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ResolveMainClassName calls getProject() at execution time, making it incompatible with Gradle's configuration cache #39644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...dle-plugin/src/main/java/org/springframework/boot/gradle/plugin/ResolveMainClassName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -47,6 +47,7 @@
* {@link Task} for resolving the name of the application's main class.
*
* @author Andy Wilkinson
* @author Yanming Zhou
* @since 2.4
*/
@DisableCachingByDefault(because = "Not worth caching")
Expand All @@ -58,6 +59,8 @@ public class ResolveMainClassName extends DefaultTask {

private final Property<String> configuredMainClass;

private final Path projectDir;

private FileCollection classpath;

/**
Expand All @@ -66,6 +69,7 @@ public class ResolveMainClassName extends DefaultTask {
public ResolveMainClassName() {
this.outputFile = getProject().getObjects().fileProperty();
this.configuredMainClass = getProject().getObjects().property(String.class);
this.projectDir = getProject().getProjectDir().toPath();
}

/**
Expand Down Expand Up @@ -153,7 +157,7 @@ Provider<String> readMainClassName() {
String classpath = getClasspath().filter(File::isDirectory)
.getFiles()
.stream()
.map((directory) -> getProject().getProjectDir().toPath().relativize(directory.toPath()))
.map((directory) -> this.projectDir.relativize(directory.toPath()))
.map(Path::toString)
.collect(Collectors.joining(","));
return this.outputFile.map(new ClassNameReader(classpath));
Expand Down