Warn in the documentation that spring.profiles.group can only be used in non-profile-specific documents #40918
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vsanna Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@vsanna Thank you for signing the Contributor License Agreement! |
vsanna
changed the title
vsanna
commented
May 28, 2024
| @@ -32,7 +32,7 @@ spring: | |||
| default: "none" | |||
| ---- | |||
|
|
|||
| `spring.profiles.active` and `spring.profiles.default` can only be used in non-profile specific documents. | |||
| `spring.profiles.active` and `spring.profiles.default` can only be used in non-profile-specific documents. | |||
There was a problem hiding this comment.
this is a trivial point, so I don't have strong preferense or opinion. I will revert if I should
wilkinsona
changed the title
wilkinsona
added
type: documentation
mhalbritter
pushed a commit
that referenced
this pull request
May 29, 2024
… in non-profile-specific documents See gh-40918
|
Thank you very much and congratulations on your first contribution 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, the official reference says that
spring.profiles.active,spring.profiles.defaultandspring.profiles.includecan only be used in non profile-specific.However, after some investigation, I believe
spring.profiles.groupalso must be in non-profile-specific configuration files.Lacking the warning made me confused a little bit. So I suppose it would be great if we have the similar section for
spring.profiles.group.What
spring.profiles.include, forspring.profiles.group