Reject binding non-uniform property key as map key #42904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
quaff
force-pushed
the
patch-87
branch
2 times, most recently
from
bc89cd6 to
bbfe04d
Compare
Given:
```yaml
my:
map:
"/key": "value"
```
---
Before this commit:
It's equivalent to
```yaml
my:
map:
"[key]": "value" # "[/key]" is expected
```
Such counter-intuitive behavior will confuse developers, there are several reported issues, incomplete list: spring-projectsGH-41099 spring-projectsGH-29582 spring-projectsGH-24548
---
After this commit:
```
***************************
APPLICATION FAILED TO START
***************************
Description:
Failed to bind properties under 'my.map' to java.util.Map<java.lang.String, java.lang.String>:
Reason: java.lang.IllegalArgumentException: Please rewrite key '/key' to '[/key]' and surround it with quotes if YAML is using
Action:
Update your application's configuration
```
---
See spring-projectsGH-42802
|
Thanks @quaff. I read your comment on the other issue but didn't have a chance to reply due to last minute work for the release. We'll discuss this one when we can. |
philwebb
added
the
for: team-meeting
|
Thanks for the PR @quaff. I agree that it would be nice to fix this, but I don't think we should put so much YAML knowledge into the |
philwebb
added
status: declined
|
I've opened #42984 so we don't forget about the issue. |
Just for friendly error message, it doesn't couple YAML and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given:
Before this commit:
It's equivalent to
Such counter-intuitive behavior will confuse developers, there are several reported issues, incomplete list: GH-41099 GH-29582 GH-24548
After this commit:
See GH-42802