-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Update org.cyclonedx.bom version in docs to 2.2.0 #44753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update org.cyclonedx.bom version in docs to 2.2.0 #44753
Conversation
2b478ac
to
4e89ce9
Compare
I assume this will need to be backported to other branches, let me know which ones. |
Arguably, the docs are correct at the moment as they're aligned with the version of the plugin that we test against. We can update the docs for 3.5 but we should update the tested version at the same time. Can you please update this PR to do that? |
Signed-off-by: Abel Salgado Romero <[email protected]>
4e89ce9
to
d0035fa
Compare
Updated but...again, and it's highly likely I am missing it. |
I don't recall the details (perhaps @mhalbritter does), but a key thing is that with these changes we'll be compiling against the version that we're recommending in the docs. |
We have some tests for the Line 660 in 4047c00
But yeah, we don't have any in |
I am not familiar enough with the tests (yet). But it seems something could be improved, let me have a look. |
See gh-44753 Signed-off-by: Abel Salgado Romero <[email protected]>
Thanks very much, @abelsromero. |
I wanted to look into the test, but I can still do that later 😅 Thanks for accepting. |
Silly update to docs.
If I understand the code correctly, cyclonedx's maven plugin is managed and updated automatically.
But SB does nothing for Gradle, so without any automatic bump, the docs still mentioned an old version.
I did some local tests and all seems to work fine. The only thing is that the default cyclonedx's version is 1.6 now, instead of 1.5.