Skip to content

Auto-configure Spring Batch to use a JobsParametersConverter bean when available #44799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Auto-configure Spring Batch to use a JobsParametersConverter bean when available #44799

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 20, 2025 •
edited
Loading

Fix GH-44793

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 20, 2025
This was referenced Mar 20, 2025
Closed
Closed
@wilkinsona
Copy link
Member

Thanks, @quaff. I think it would be better to handle jobParametersConverter separately, particularly as it isn't configured using a property. Could you pull that out into a separate PR please?

@quaff
Copy link
Contributor Author

quaff commented Mar 20, 2025

Thanks, @quaff. I think it would be better to handle jobParametersConverter separately, particularly as it isn't configured using a property. Could you pull that out into a separate PR please?

Sure.

wilkinsona
wilkinsona requested changes Mar 20, 2025
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the max varchar length either given how tightly coupled it is to the schema. Being able to configure validateTransactionState looks useful though. Can we just focus on that please in this PR?

@quaff quaff changed the title Autoconfigure more properties for Spring Batch Add possibility to configure a custom JobParametersConverter in BatchAutoConfiguration Mar 20, 2025
@wilkinsona wilkinsona changed the title Add possibility to configure a custom JobParametersConverter in BatchAutoConfiguration Auto-configure Spring Batch to use a JobsParametersConverter bean when available Mar 20, 2025
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2025
@wilkinsona wilkinsona added this to the 3.5.x milestone Mar 20, 2025
@wilkinsona wilkinsona self-assigned this Mar 20, 2025
@wilkinsona wilkinsona modified the milestones: 3.5.x, 3.5.0-M3 Mar 20, 2025
wilkinsona pushed a commit that referenced this pull request Mar 20, 2025
@quaff @wilkinsona
Auto-configu Batch to use JobsParametersConverter bean when available
7af7820 
See gh-44799

Signed-off-by: Yanming Zhou <[email protected]>
@wilkinsona
Copy link
Member

Thanks again, @quaff.

@pPanda-beta
Copy link

Very silly question @wilkinsona is this PR merged via a separate commit or rejected?

4ff0061 seems like an identical commit

@wilkinsona
Copy link
Member

It was merged in 4ff0061. Unfortunately, limitations of GitHub's web UI cause it to appear unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona requested changes

Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-M3
Development

Successfully merging this pull request may close these issues.

Allow overriding JobParametersConverter for spring batch auto-configuration
4 participants
@quaff @wilkinsona @pPanda-beta @spring-projects-issues