Rename 'spring.http.client' properties to 'spring.http.clients' #44962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Shivam Thorat <[email protected]>
shivammm21
force-pushed
the
rename-http-client-properties-44958
branch
from
74792de to
d2633b7
Compare
|
Thanks for this PR but the issue is already assigned so I assume that Phil has already started working on this. Also, renaming the property is not enough as additional metadata must be added to help IDEs and the properties migrator with the renaming. |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the properties from
spring.http.clienttospring.http.clientsto follow the same pattern used elsewhere in Spring Boot (likeproperties.actuator.management.endpoints).The change affects
HttpClientPropertiesclass configuration propertyThis is a breaking change for anyone already using the
spring.http.client.*properties in the 3.4.0 milestone.Fixes #44958