Support per-meter configuration for OtlpMetricsProperties #45203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds configuration properties support for the new OtlpConfig methods `histogramFlavorPerMeter` and `maxBucketsPerMeter`. The existing `histogramFlavor` and `maxBucketCount` configuration properties are used as defaults when there isn't a specific per-meter configuration set.
spring-projects-issues
added
the
status: waiting-for-triage
shakuzen
commented
Apr 15, 2025
| @@ -1548,7 +1548,7 @@ bom { | |||
| releaseNotes("https://github.com/apache/maven-war-plugin/releases/tag/maven-war-plugin-{version}") | |||
| } | |||
| } | |||
| library("Micrometer", "1.15.0-SNAPSHOT") { | |||
| library("Micrometer", "1.15.0-RC1") { | |||
There was a problem hiding this comment.
Sorry, this change isn't necessary since Boot is already on snapshots. When I started making the changes for the PR, this was still on M3.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
philwebb
added
type: enhancement
philwebb
pushed a commit
that referenced
this pull request
Apr 15, 2025
Add configuration properties support for the new `OtlpConfig` methods `histogramFlavorPerMeter` and `maxBucketsPerMeter`. The existing `histogramFlavor` and `maxBucketCount` configuration properties are used as defaults when there isn't a specific per-meter configuration set. See gh-45203
philwebb
added a commit
that referenced
this pull request
Apr 15, 2025
|
Thanks @shakuzen! I've slightly reworked the properties: Old:
New:
|
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration properties support for the new OtlpConfig methods
histogramFlavorPerMeterandmaxBucketsPerMeter. The existinghistogramFlavorandmaxBucketCountconfiguration properties are used as defaults when there isn't a specific per-meter configuration set.See micrometer-metrics/micrometer#5974