Skip to content

support profile negation in YAML subdocuments #4953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

support profile negation in YAML subdocuments #4953

wants to merge 1 commit into from
+179 −3

Conversation

mbenson
Copy link
Contributor

@mbenson mbenson commented Jan 15, 2016

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2016
@mbenson
Copy link
Contributor Author

mbenson commented Feb 3, 2016

gitter conversation with @dsyer yielded the decision to rework this:

  • remove parentheses notation, forcing negation of multiple profiles to specify individual ! characters
  • if negated and non-negated profiles are specified in a single document, some non-negated profile must match and no negated profiles must match; document this rule

@mbenson
Copy link
Contributor Author

mbenson commented Feb 22, 2016

I have made the changes discussed above.

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 26, 2016
@philwebb philwebb added this to the 1.4.0.M2 milestone Feb 26, 2016
philwebb pushed a commit that referenced this pull request Apr 11, 2016
@mbenson @philwebb
Support profile negation in YAML sub-documents
bd01049 
See gh-4953
@philwebb philwebb closed this in a39d351 Apr 11, 2016
philwebb added a commit that referenced this pull request Apr 11, 2016
@philwebb
Merge pull request #4953 from mbenson/notprofilesyaml
35bec96 
* notprofilesyaml:
  Polish profile negation in YAML sub-documents
  Support profile negation in YAML sub-documents
@philwebb
Copy link
Member

Merged. Thanks, especially for all the test cases!

This was referenced Apr 20, 2016
Closed
Closed
snicoll pushed a commit that referenced this pull request Apr 21, 2016
@mbenson @snicoll
Polish
b9aee36 
See gh-4953
Closes gh-5745
philwebb pushed a commit that referenced this pull request Apr 25, 2016
@mbenson @philwebb
Fix SpringProfileDocumentMatcher negation bug
15d6662 
Prior to this commit SpringProfileDocumentMatcher was returning 'found'
anytime a negated profile was not found, even if there were positive
profile matches required and unsatisfied.

Closes gh-5747
See gh-4953
@wilkinsona wilkinsona mentioned this pull request Jan 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.4.0.M2
Development

Successfully merging this pull request may close these issues.
3 participants
@mbenson @philwebb @spring-projects-issues