Skip to content

[DATACMNS-1735] Fix ConcurrencyModificationException without synchronized block #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DATACMNS-1735] Fix ConcurrencyModificationException without synchronized block #446

wants to merge 1 commit into from

Conversation

mhyeon-lee
Copy link
Contributor

@mhyeon-lee mhyeon-lee commented May 27, 2020 •
edited
Loading

resolves DATACMNS-1735

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@mhyeon-lee mhyeon-lee changed the title [DATACMNS-1735] Fix ConcurrencyModificationException with synchronize… [DATACMNS-1735] Fix ConcurrencyModificationException with synchronized block May 27, 2020
@mhyeon-lee mhyeon-lee force-pushed the datacmns-1735-synchronized-for-concurrency-modification-exception branch from c3bf898 to 094b37a Compare May 27, 2020 06:13
@mhyeon-lee mhyeon-lee changed the title [DATACMNS-1735] Fix ConcurrencyModificationException with synchronized block [DATACMNS-1735] Fix ConcurrencyModificationException without synchronized block May 27, 2020
mp911de pushed a commit that referenced this pull request May 27, 2020
@mp911de
DATACMNS-1735 - Fix ConcurrencyModificationException in EntityCallbac…
d9969cb 
…kDiscoverer.

We now guard modifications of the cached entity callbacks list with a synchronization block.

Original pull request: #446.
mp911de added a commit that referenced this pull request May 27, 2020
@mp911de
DATACMNS-1735 - Polishing.
c991685 
Use mutated object as guard for synchronization.

Reduce concurrency in unit test to reduce test load. Guard synchronization with timeouts.

Original pull request: #446.
mp911de pushed a commit that referenced this pull request May 27, 2020
@mp911de
DATACMNS-1735 - Fix ConcurrencyModificationException in EntityCallbac…
0e95440 
…kDiscoverer.

We now guard modifications of the cached entity callbacks list with a synchronization block.

Original pull request: #446.
mp911de added a commit that referenced this pull request May 27, 2020
@mp911de
DATACMNS-1735 - Polishing.
4358045 
Use mutated object as guard for synchronization.

Reduce concurrency in unit test to reduce test load. Guard synchronization with timeouts.

Original pull request: #446.
@mp911de
Copy link
Member

mp911de commented May 27, 2020

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this May 27, 2020
mp911de added a commit that referenced this pull request May 27, 2020
@mp911de
DATACMNS-1735 - Polishing.
fbe51ef 
Use mutated object as guard for synchronization. Copy discovered callbacks to cached callbacks.

Reduce concurrency in unit test to reduce test load. Guard synchronization with timeouts.

Original pull request: #446.
mp911de added a commit that referenced this pull request May 27, 2020
@mp911de
DATACMNS-1735 - Polishing.
a8aa074 
Use mutated object as guard for synchronization. Copy discovered callbacks to cached callbacks.

Reduce concurrency in unit test to reduce test load. Guard synchronization with timeouts.

Original pull request: #446.
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhyeon-lee @mp911de