Add Vector type support #3009
Closed
Add Vector type support #3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
requested changes
Apr 28, 2025
| @@ -308,6 +308,17 @@ public Statement prepareSaveOf(NodeDescription<?> nodeDescription, | |||
| Assert.notNull(idDescription, "Cannot save individual nodes without an id attribute"); | |||
| Parameter<?> idParameter = parameter(Constants.NAME_OF_ID); | |||
|
|
|||
| Function<StatementBuilder.OngoingMatchAndUpdate, Statement> vectorProcedureCall = (bs) -> { | |||
michael-simons
approved these changes
May 5, 2025
Comment on lines
222
to
223
| But on the database-side those values will be persisted as `doubles` for the time being to support manual persisted arrays and | ||
| values persisted through `setNodeVectorProperty`. |
There was a problem hiding this comment.
Bitte so:
Neo4j will store both double and float variants as a 64bit Cypher FLOAT value, which is consistent with values persisted through Cypher and the dedicated setNodeVectorProperty function that Spring Data Neo4j uses to persist the property.
This commit combines Spring Data Commons' Vector type with the Neo4j vector functionality. Fields defined as Spring Data Commons `Vector` will get persisted through the `setNodeVectorProperty` procedure. Closes #3003 Signed-off-by: Gerrit Meier <[email protected]>
meistermeier
force-pushed
the
issue/gh-3003
branch
from
f80bfac to
5d57819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map
org.springframework.data.domain.VectortosetNodeVectorPropertyprocedure call.Open documentation tasks
doublevector in SDN onlyNote to myself, there should be a close the issue commit on squash.