Skip to content

StaticMasterReplicaConnectionProvider throws exception on getConnectionAsync #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cfredri4 opened this issue Apr 5, 2022 · 1 comment
Closed

StaticMasterReplicaConnectionProvider throws exception on getConnectionAsync #2296

cfredri4 opened this issue Apr 5, 2022 · 1 comment
Assignees
@mp911de
Labels
type: bug A general bug
Milestone
2.5.11 (2021.0.11)

Comments

@cfredri4
Copy link

cfredri4 commented Apr 5, 2022

Return statement is missing?

spring-data-redis/src/main/java/org/springframework/data/redis/connection/lettuce/StaticMasterReplicaConnectionProvider.java

Line 93 in fea6e78

connection.thenApply(it -> {

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 5, 2022
@cfredri4 cfredri4 changed the title LettuceConnectionFactory throw error on all reactive subscribes LettuceConnectionFactory throw error on reactive subscribes with master-replica Apr 5, 2022
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 6, 2022
@mp911de mp911de changed the title LettuceConnectionFactory throw error on reactive subscribes with master-replica StaticMasterReplicaConnectionProvider throws exception on getConnectionAsync` Apr 6, 2022
@mp911de mp911de self-assigned this Apr 6, 2022
@mp911de mp911de changed the title StaticMasterReplicaConnectionProvider throws exception on getConnectionAsync` StaticMasterReplicaConnectionProvider throws exception on getConnectionAsync Apr 6, 2022
@mp911de mp911de added this to the 2.5.11 (2021.0.11) milestone Apr 6, 2022
@mp911de mp911de closed this as completed in e0f4937 Apr 6, 2022
mp911de added a commit that referenced this issue Apr 6, 2022
@mp911de
Correctly return connection future from StaticMasterReplicaConnection…
ccb4fe4 
…Provider.

We now pass on the connection future when connecting through StaticMasterReplicaConnectionProvider.getConnectionAsync(…).

Closes #2296
mp911de added a commit that referenced this issue Apr 6, 2022
@mp911de
Correctly return connection future from StaticMasterReplicaConnection…
cc04e3f 
…Provider.

We now pass on the connection future when connecting through StaticMasterReplicaConnectionProvider.getConnectionAsync(…).

Closes #2296
mp911de added a commit that referenced this issue Apr 6, 2022
@mp911de
Correctly return connection future from StaticMasterReplicaConnection…
0538bd5 
…Provider.

We now pass on the connection future when connecting through StaticMasterReplicaConnectionProvider.getConnectionAsync(…).

Closes #2296
@mp911de
Copy link
Member

mp911de commented Apr 6, 2022

Good catch, that's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
2.5.11 (2021.0.11)
Development

No branches or pull requests
3 participants
@mp911de @spring-projects-issues @cfredri4