Skip to content

RedisNode creation from bare hostname should assign default port #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lukasz-glapinski-exa opened this issue Jun 15, 2024 · 2 comments
Closed

RedisNode creation from bare hostname should assign default port #2928

lukasz-glapinski-exa opened this issue Jun 15, 2024 · 2 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
3.4 RC1 (2024.1.0)

Comments

@lukasz-glapinski-exa
Copy link

Current code is expecting node information to not contain port but is not assigning default port to portString variable resulting in exception being thrown.

spring-data-redis/src/main/java/org/springframework/data/redis/connection/RedisNode.java

Line 97 in a7d3914

host = hostPortString;

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 15, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 17, 2024
@mp911de mp911de self-assigned this Jun 17, 2024
@LeeHyungGeol
Copy link
Contributor

LeeHyungGeol commented Sep 21, 2024 •
edited
Loading

Hi @mp911de. May I handle this issue? I'll create PR within tomorrow.

@LeeHyungGeol LeeHyungGeol mentioned this issue Sep 22, 2024
Closed
4 tasks
@LeeHyungGeol
Copy link
Contributor

Fix PR: #3002

@mp911de mp911de linked a pull request Oct 10, 2024 that will close this issue
RedisNode creation from bare hostname assigns default port #3002
Closed
4 tasks
@mp911de mp911de added this to the 3.4 RC1 (2024.1.0) milestone Oct 10, 2024
mp911de added a commit that referenced this issue Oct 10, 2024
@mp911de
Polishing.
20ceb4c 
Introduce factory method overload accepting the default port so that Sentinel uses the right port.
Refine tests. Refine Javadoc.

See #2928
Original pull request: #3002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4 RC1 (2024.1.0)
Development

Successfully merging a pull request may close this issue.

RedisNode creation from bare hostname assigns default port LeeHyungGeol/spring-data-redis
4 participants
@mp911de @spring-projects-issues @LeeHyungGeol @lukasz-glapinski-exa