Use JUnit 5.13 @ParametrizedClass
#3175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate to JUnit's class parametrization and remove our own ParameterizedRedisTest infrastructure. Class parametrization considers closeable arguments and closes these. Therefore, ManagedJedisConnectionFactory and ManagedLettuceConnectionFactory are now no longer Closable but closed through the ShutdownQueue on JVM exit so that we don't need to guard these from Class parametrization cleanup. Also, we register extensions with the launcher value store to keep instances as long as possible. Exclude commons-logging from beanutils so that we use the version managed by Spring that considers SLF4j loggers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to JUnit's class parametrization and remove our own
@ParameterizedRedisTestinfrastructure.Class parametrization considers closeable arguments and closes these. Therefore, ManagedJedisConnectionFactory and ManagedLettuceConnectionFactory are now no longer Closable but closed through the ShutdownQueue on JVM exit so that we don't need to guard these from Class parametrization cleanup.
Also, we register extensions with the launcher value store to keep instances as long as possible.
Exclude commons-logging from beanutils so that we use the version managed by Spring that considers SLF4j loggers.
Closes #3167