A custom annotation above the method to generate SQL by the name of the method

[KirillKurdyukov]

I'm trying to make an annotation that will participate in SQL generation on a spring-data-jdbc. You can say this is a hint for using an index in a database. It can look like:

@UseIndex("name_index")
findByName(String name)

I found a way to implement an interceptor from JdbcRepositoryFactoryBean:

    class UseIndexInterceptor : MethodInterceptor {

        override fun invoke(invocation: MethodInvocation): Any? {
            val useIndex = invocation.method.getAnnotation(UseIndex::class.java)
            threadBoundUseIndex.set(useIndex)
            try {
                return invocation.proceed()
            } finally {
                threadBoundUseIndex.remove()
            }
        }
    }

And use it in MySelectRenderContext

And the question is, is it possible to do something better?

[mp911de]

Methods invoked on the repository interface are already exposed in a thread-bound arrangement through ExposeInvocationInterceptor. You can obtain the currently invoked method by calling ExposeInvocationInterceptor.currentInvocation().

[KirillKurdyukov]

Thank you very much, Mark! I will use this static method in my dialect now!
If I understood correctly:

    @Override
    protected Function<Select, CharSequence> getAfterFromTable() {
        return select -> {
            var tables = select.getFrom().getTables();
            if (tables.size() != 1) {
                return "";
            }

            var viewIndex = ExposeInvocationInterceptor.currentInvocation().getMethod().getAnnotation(ViewIndex.class);
            
            var tableName = tables.get(0).getReferenceName();

            return viewIndex != null ?
                    "VIEW " + viewIndex.name() + " AS " + tableName : "";
        };
    }

[KirillKurdyukov]

Spring version: 3.4.2 :(
(For 3.2.1 it is working)

java.lang.IllegalStateException: No MethodInvocation found: Check that an AOP invocation is in progress and that the ExposeInvocationInterceptor is upfront in the interceptor chain. Specifically, note that advices with order HIGHEST_PRECEDENCE will execute before ExposeInvocationInterceptor! In addition, ExposeInvocationInterceptor and ExposeInvocationInterceptor.currentInvocation() must be invoked from the same thread.

[KirillKurdyukov]

Hi @mp911de,

Could you please help me ? Any advice would be much appreciated!

[mp911de]

With spring-projects/spring-data-commons#3090 (Spring Data 3.4) we disabled default metadata exposure to be less resource-intensive. You can enable exposing invocation metadata by setting RepositoryFactoryBeanSupport.setExposeMetadata(true), ideally through a BeanPostProcessor.postProcessBeforeInitialization(…).