-
Notifications
You must be signed in to change notification settings - Fork 364
Add failing test with multiple joins and InlineQuery
#1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4a5933d
to
57463d7
Compare
ed66198
to
b746be5
Compare
I've been able to make the test a bit smaller with less conditions and clauses. But after spending quite some time I haven't been able to find what should be changed to let this behave correctly. Somewhere between Unfortunately I don't know enough about the visitor/delegation setup to find the actual cause. |
Adds a test demonstrating that the join condition of inline queries messes up those of outer joins. Original pull request #1362
Before this fix, whenever a column of an inline query was rendered the `InlineQuery` and all its children were visited, resulting in spurious output. This is no prevented by injecting a NoopVisitor. Closes #1362
Before this fix, whenever a column of an inline query was rendered the `InlineQuery` and all its children were visited, resulting in spurious output. This is no prevented by injecting a NoopVisitor. Closes #1362
I created a fresh PR which includes your (simplified) tests plus a fix: #1368 |
Adds a test demonstrating that the join condition of inline queries messes up those of outer joins. Original pull request #1362
Before this fix, whenever a column of an inline query was rendered the `InlineQuery` and all its children were visited, resulting in spurious output. This is no prevented by injecting a NoopVisitor. Closes #1362
Before this fix, whenever a column of an inline query was rendered the `InlineQuery` and all its children were visited, resulting in spurious output. This is no prevented by injecting a NoopVisitor. Closes #1362
Before this fix, whenever a column of an inline query was rendered the `InlineQuery` and all its children were visited, resulting in spurious output. This is no prevented by injecting a NoopVisitor. Closes #1362
I'm not sure yet how I should approach this problem, but it seems that somehow where clauses of the inline query are partly reused in the outer query, resulting in invalid SQL.
To clarify, the test result is: