Skip to content

Add default JDBCType.NULL for null values #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

serezakorotaev
Copy link
Contributor

Hi every one!
This PR for issue

I added default jdbcType value for null value from entity

@schauder schauder self-requested a review June 4, 2025 10:29
@schauder schauder self-assigned this Jun 4, 2025
@schauder schauder added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 4, 2025
schauder pushed a commit that referenced this pull request Jun 4, 2025
Signed-off-by: Sergey Korotaev <[email protected]>

Original pull request #2068
Closes #1935
schauder added a commit that referenced this pull request Jun 4, 2025
Improved naming and formatting

Original pull request #2068
See #1935
schauder added a commit that referenced this pull request Jun 4, 2025
Not all databases support the JDBCSqlType.NULL.
Therefore this handling was made dialect dependent, with SQL Server and DB2 using the old approach, while all others use JDBCSqlType.NULL

In the process modified AbstractJdbcConfiguration to use JdbcDialect instead of Dialect.

Original pull request #2068
See #1935
See #2031
schauder added a commit that referenced this pull request Jun 4, 2025
Remove unused fields in TestConfiguration.

Original pull request #2068
See #1935
@schauder
Copy link
Contributor

schauder commented Jun 4, 2025

The idea is good and I think correct.
Unfortunately the integration tests with various databases show that JDBCType.NULL is not supported by SQL Server and DB2. Therefore the null handling has to be Dialect dependent.

I created #2069 based on this PR.

Thanks for tackling this issue and for pointing me in the right direction!

@schauder schauder closed this Jun 4, 2025
@serezakorotaev
Copy link
Contributor Author

I'm glad to help! :)
I'm sorry that my decision was a bit wrong :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants