Fix derived queries with boolean literals. #983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
added a commit
that referenced
this pull request
May 31, 2021
`IsTrue` and `IsFalse` queries no longer use a literal in the query, but a bind parameter. This allows Spring Data JDBC or the JDBC driver to convert the passed boolean value to whatever is required in the database. For Oracle converter where added to support storing and loading booleans as NUMBER(1,0) where 0 is false and everything else is true. Closes #908 Original pull request #983
schauder
force-pushed
the
issue/908-boolean-for-derived-queries
branch
from
46826bc to
1a581b2
Compare
`IsTrue` and `IsFalse` queries no longer use a literal in the query, but a bind parameter. This allows Spring Data JDBC or the JDBC driver to convert the passed boolean value to whatever is required in the database. For Oracle converter where added to support storing and loading booleans as NUMBER(1,0) where 0 is false and everything else is true. Closes #908 Original pull request #983
schauder
force-pushed
the
issue/908-boolean-for-derived-queries
branch
from
1a581b2 to
b32beaa
Compare
|
Rebased, added test to demonstrate interaction of converters registered by Added and cleaned up documentation, which was spread across two places. |
mp911de
pushed a commit
that referenced
this pull request
Jun 10, 2021
`IsTrue` and `IsFalse` queries no longer use a literal in the query, but a bind parameter. This allows Spring Data JDBC or the JDBC driver to convert the passed boolean value to whatever is required in the database. For Oracle converter where added to support storing and loading booleans as NUMBER(1,0) where 0 is false and everything else is true. Closes #908 Original pull request #983
|
That's merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsTrueandIsFalsequeries no longer use a literal in the query, but a bind parameter.This allows Spring Data JDBC or the JDBC driver to convert the passed boolean value to whatever is required in the database.
For Oracle converter where added to support storing and loading booleans as NUMBER(1,0) where 0 is false and everything else is true.
Closes #908